Allow multiple agent.Close #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #718 +/- ##
==========================================
+ Coverage 79.17% 79.22% +0.04%
==========================================
Files 41 41
Lines 3780 3779 -1
==========================================
+ Hits 2993 2994 +1
+ Misses 556 555 -1
+ Partials 231 230 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sean-Der
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a case in webrtc GracefulClose (https://github.com/pion/webrtc/pull/2847/files#diff-61936a3824ea2f65378ca63d509769a4dc6b52a1685845f764089fe03de2f4c3R213-R216) where it would be beneficial to wait for the ICE agent to gracefully close but due to how Mux works, it's hard to thread it through without calling GracefulClose and then Close on the agent. That makes an error happen that doesn't seem necessary. If you close twice, that feels okay.