Update turn to v1.3.2 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update pion/transport to v0.8.6 Relates to pion/webrtc#740
TURN client's loc conn was not closed when agent.Close() was called Relates to pion/webrtc#740
|
@Sean-Der Now, what is failing is |
Closed
Sean-Der
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to pion/webrtc#740
The test with the PR (pion/webrtc#740) was failing because pion/turn had an unportable code which was caused the build failure for wasm.
This PR includes pion/turn@v1.3.2 which removed the offending code.
Also, there was a bug in CandidateRelay. TURN client's local conn (socket) was not closed on Agent.Close(), (was closing relayConn twice instead) and was causing "unexpected goroutine error".