Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter packets and reports by SSRC #184

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Filter packets and reports by SSRC #184

merged 1 commit into from
Apr 26, 2023

Conversation

mengelbart
Copy link
Contributor

Otherwise, we would record packets and reports which do not belong to the stream that is monitored by this recorder.

Reference issue

Fixes #166 #168

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 88.00% and project coverage change: +0.54 🎉

Comparison is base (71346d6) 78.95% compared to head (531eebf) 79.49%.

❗ Current head 531eebf differs from pull request most recent head 1e0e0ad. Consider uploading reports for the commit 1e0e0ad to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   78.95%   79.49%   +0.54%     
==========================================
  Files          66       66              
  Lines        3321     3350      +29     
==========================================
+ Hits         2622     2663      +41     
+ Misses        579      570       -9     
+ Partials      120      117       -3     
Flag Coverage Δ
go 79.49% <88.00%> (+0.54%) ⬆️
wasm 77.07% <88.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/stats/stats_recorder.go 84.51% <88.00%> (+4.04%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Otherwise we would record packets and reports which do not belong to the
stream that is monitored by this recorder.
@Sean-Der Sean-Der merged commit 3f299e1 into master Apr 26, 2023
@Sean-Der Sean-Der deleted the fix/issue-166 branch April 26, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Stats recorder SSRC handling for PLI/NACK/FIR/...
2 participants