Force key frame on PLI #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmrysMyrddin
changed the title
EmrysMyrddin
force-pushed
the
force-key-frame-on-pli
branch
4 times, most recently
from
456950d
to
668f0fb
Compare
at-wat
reviewed
Jul 12, 2021
EmrysMyrddin
force-pushed
the
force-key-frame-on-pli
branch
3 times, most recently
from
97035d2
to
e2b71a1
Compare
|
Stil waiting for pion/webrtc#1812 to be merged for being able to make this PR ready to merge. Do you have any insigh on what I can do to make it happen ? |
EmrysMyrddin
force-pushed
the
force-key-frame-on-pli
branch
from
9de29da
to
b1f7693
Compare
Sean-Der
reviewed
Jul 25, 2022
.idea/misc.xml
Outdated
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
@EmrysMyrddin Remove this file please
EmrysMyrddin
force-pushed
the
force-key-frame-on-pli
branch
from
662d1ac
to
0b71f7c
Compare
Sean-Der
force-pushed
the
force-key-frame-on-pli
branch
4 times, most recently
from
7ad4cfc
to
f687012
Compare
Also make the ReadCloser an Controllable allows to uncouple the controller implementation from the encoder. This is not needed for the 2 codec controller already implemented (openh264 and vpx) but is more future proof in case it required for other codecs.
Sean-Der
force-pushed
the
force-key-frame-on-pli
branch
from
f687012
to
fcefdd4
Compare
Sean-Der
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a first POC around handling PLI for codecs on which we have control over key frame generation.
I have added the idea of an
EncoderControllerinstead of addingForceKeyFrameandSetBitRatedirectly on theReadCloserinterface.This allows more flexibility on encoder implementation. The main benefit is that you can optionally implement bit rate and key frame control. In our case, only 2 codecs have this implementations.
Using interfaces for each controls allows to check if an encoder have this controls and enable features only on compatible encoders.
The next step probably to add handling of bit rate negotiation packets, but this PR is already pretty long so I don't want to put too much stuff in it for now.
Reference issue
This PR needs some modification in the
pion/webrtcpackage for being able to read RTCP feedbacks. Here is the related PR that needs to be merged before this one: pion/webrtc#1812