Allow to use user defined Track #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add WithTrackGenerator option to specify TrackGenerator. This allows user to replace Track by user defined one that has WriteSample() and Codec() interface.
lherman-cs
approved these changes
Feb 13, 2020
| @@ -21,14 +21,19 @@ type Tracker interface { | |||
| OnEnded(func(error)) | |||
| } | |||
|
|
|||
| type LocalTrack interface { | |||
There was a problem hiding this comment.
I actually kinda discussed this with Sean about this. I believe right now pion/webrtc is moving to 3.0, https://github.com/pion/webrtc/tree/v3, and he's open to adding some breaking changes. So, I was wondering if we should make a change in pion/webrtc to convert Track to be an interface. That way we can simply reuse the interface from pion/webrtc and simplify this file.
There was a problem hiding this comment.
But, for now, we can definitely keep this.
There was a problem hiding this comment.
Yea, it would be very nice to have it in pion/webrtc in v3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WithTrackGenerator option to specify TrackGenerator.
This allows user to replace Track by user defined one that
has WriteSample() and Codec() interface.
So that we can get encoded media streams directly from MediaDevices.