Add PaddingSize to rtp.Packet #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a packet has padding, the padding size information is lost during unmarshal. Add a PaddingSize field to Packet structure. Also support marshalling on an RTP packet with padding. Testing: -------- Modified/added unit tests.
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 93.06% 93.31% +0.24%
==========================================
Files 14 14
Lines 937 942 +5
==========================================
+ Hits 872 879 +7
+ Misses 46 45 -1
+ Partials 19 18 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sean-Der
approved these changes
Nov 22, 2021
Closed
aler9
added a commit
to aler9/rtp
that referenced
this pull request
Mar 8, 2022
A Marshal function shouldn't change any property of the object that is being marshaled. Otherwise, Marshal() is non-thread safe and can't be called by multiple goroutines in parallel. PR pion#155 makes Packet.Marshal() set the Packet.Header.Padding bit when Packet.PaddingSize is non-zero; while this is preferable from the user point of view, it doesn't allow thread safety. This patch fixes the issue.
aler9
added a commit
to aler9/rtp
that referenced
this pull request
Mar 8, 2022
A Marshal function shouldn't change any property of the object that is being marshaled. Otherwise, Marshal() is non-thread safe and can't be called by multiple goroutines in parallel. PR pion#155 makes Packet.Marshal() set the Packet.Header.Padding bit when Packet.PaddingSize is non-zero; while this is preferable from the user point of view, it doesn't allow thread safety. This patch fixes the issue.
aler9
added a commit
to aler9/rtp
that referenced
this pull request
Mar 8, 2022
A Marshal function shouldn't change any property of the object that is being marshaled. Otherwise, Marshal() is non-thread safe and can't be called by multiple goroutines in parallel. PR pion#155 makes Packet.Marshal() set the Packet.Header.Padding bit when Packet.PaddingSize is non-zero; while this is preferable from the user point of view, it doesn't allow thread safety. This patch fixes the issue.
aler9
added a commit
to aler9/rtp
that referenced
this pull request
Mar 17, 2022
A Marshal function shouldn't change any property of the object that is being marshaled. Otherwise, Marshal() is non-thread safe and can't be called by multiple goroutines in parallel. PR pion#155 makes Packet.Marshal() set the Packet.Header.Padding bit when Packet.PaddingSize is non-zero; while this is preferable from the user point of view, it doesn't allow thread safety. This patch fixes the issue.
aler9
added a commit
that referenced
this pull request
Mar 17, 2022
A Marshal function shouldn't change any property of the object that is being marshaled. Otherwise, Marshal() is non-thread safe and can't be called by multiple goroutines in parallel. PR #155 makes Packet.Marshal() set the Packet.Header.Padding bit when Packet.PaddingSize is non-zero; while this is preferable from the user point of view, it doesn't allow thread safety. This patch fixes the issue.
But even with marshalled packet, the plaintext will always be unmarshalled and its padding info is thrown away: both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a packet has padding, the padding size information
is lost during unmarshal. Add a PaddingSize field to
Packet structure.
Also support marshalling on an RTP packet with padding.
Testing:
Modified/added unit tests.