Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit maximum tsn queued by the association #323

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Apr 2, 2024

We can only ACK TSN offsets 64k from the cummulativeTSN so there's no point queuing higher TSNs

@sukunrt sukunrt requested a review from MarcoPolo April 2, 2024 16:04
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.18%. Comparing base (338310b) to head (777111e).

Files Patch % Lines
association.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   81.01%   81.18%   +0.16%     
==========================================
  Files          49       49              
  Lines        4178     4188      +10     
==========================================
+ Hits         3385     3400      +15     
+ Misses        650      646       -4     
+ Partials      143      142       -1     
Flag Coverage Δ
go 81.18% <76.92%> (+0.16%) ⬆️
wasm 67.40% <69.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoPolo MarcoPolo force-pushed the fix-window-size branch 2 times, most recently from 3d6e311 to aa3a95a Compare April 2, 2024 23:01
@MarcoPolo MarcoPolo merged commit f0386f2 into master Apr 3, 2024
15 checks passed
@MarcoPolo MarcoPolo deleted the fix-window-size branch April 3, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants