Prevent reassembly queue getting stuck #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the queue is full but is not readable and an ordered chunk arrives, push it anyway, otherwise the queue may be stuck as unreadable forever
hugoArregui
changed the title
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
- Coverage 75.95% 75.93% -0.03%
==========================================
Files 43 43
Lines 2620 2626 +6
==========================================
+ Hits 1990 1994 +4
- Misses 508 509 +1
- Partials 122 123 +1
Continue to review full report at Codecov.
|
hugoArregui
force-pushed
the
topic-ordered-fix
branch
2 times, most recently
from
e1acbc0
to
88cecef
Compare
Linter fixes
Relates to #63
enobufs
approved these changes
Sep 28, 2019
There was a problem hiding this comment.
Nice work @hugoArregui
I really love seeing some step up and go for fixing problems even in the unfamiliar area.
My producible test using vnet has proven your fix works! Hi-five!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the queue is full but is not readable and an ordered chunk arrives, push it anyway, otherwise the queue may be stuck as unreadable forever.
Related #63