Improved generateChecksum performance. (4x) #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to #49 |
The old code is egregious so I had to fix it. It would make a copy of each packet just to unset 4 bytes. It would also create a crc32 table each time, which is fortunately cached but requires a mutex lock. benchmark old ns/op new ns/op delta BenchmarkPacketGenerateChecksum-8 284 68.2 -75.99%
kixelated
force-pushed
the
checksum-perf
branch
from
56adc20
to
d703a4b
Compare
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=========================================
- Coverage 76.91% 76.9% -0.01%
=========================================
Files 43 43
Lines 2712 2711 -1
=========================================
- Hits 2086 2085 -1
Misses 497 497
Partials 129 129
Continue to review full report at Codecov.
|
AeroNotix
approved these changes
Oct 27, 2019
|
@kixelated please update the commit message as per the format in the CI log and I'll be happy to merge! |
|
@kixelated hi! Would love to merge this. Please update the commit message and I'll click that merge button. |
|
Fantastic, thank you so much @kixelated merged as ced24b2 Thanks for the approve @AeroNotix I just forced pushed to the branch and fixed it up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code is egregious so I had to fix it. It would make a copy of
each packet just to unset 4 bytes. It would also create a crc32 table
each time, which is fortunately cached but requires a mutex lock.