Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export unexported functions #259

Closed
wants to merge 2 commits into from
Closed

Conversation

potaga
Copy link

@potaga potaga commented Feb 20, 2024

Description

For performance reasons, some projects need to bypass part of the standard pion path and access the SRTP session directly. This PR exports the required functions.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 76.36%. Comparing base (cc85f6c) to head (6d472c3).

Files Patch % Lines
session_srtp.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
- Coverage   76.73%   76.36%   -0.37%     
==========================================
  Files          17       17              
  Lines        1255     1261       +6     
==========================================
  Hits          963      963              
- Misses        200      206       +6     
  Partials       92       92              
Flag Coverage Δ
go 76.36% <0.00%> (-0.37%) ⬇️
wasm 75.89% <0.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der
Copy link
Member

We are able to circumvent the SRTP APIs using SettingEngine.BufferFactory

@Sean-Der Sean-Der closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants