Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: Outbound packet larger than maximum message size 65535 #1396

Open
enobufs opened this issue Sep 3, 2020 · 1 comment
Open

Error: Outbound packet larger than maximum message size 65535 #1396

enobufs opened this issue Sep 3, 2020 · 1 comment
Assignees
@enobufs
Labels
bug Something isn't working

Comments

@enobufs
Copy link
Member

enobufs commented Sep 3, 2020

Your environment.

  • Version: pion/webrtc@v2.2.24
  • Browser: n/a

What did you do?

Try to send data channel message with length 64KB

What did you expect?

Successfully sent.

What happened?

Errored with:

 Outbound packet larger than maximum message size 65535

Here's where the error originates.

There are three problems:

  1. By default it should allow 64KB
  2. SCTPTransport has remoteMaxMessageSize, but this doesn't get propagated to pion/sctp
  3. remoteMaxMessageSize should be updated based on max-message-size in SDP.

@Sean-Der do we parse max-message-size in SDP, and do we send it?
enobufs added a commit to pion/sctp that referenced this issue Sep 8, 2020
@enobufs
Set default MaxMessageSize to 65536
f323feb 
Added getter/setter function also
Relates to pion/webrtc#1396
@enobufs enobufs mentioned this issue Sep 8, 2020
Merged
enobufs added a commit to pion/sctp that referenced this issue Sep 12, 2020
@enobufs
Set default MaxMessageSize to 65536
d1f92a8 
Added getter/setter function also
Relates to pion/webrtc#1396
enobufs added a commit to pion/sctp that referenced this issue Sep 12, 2020
@enobufs
Set default MaxMessageSize to 65536
25c274f 
Added getter/setter function also
Relates to pion/webrtc#1396
@enobufs
Copy link
Member Author

enobufs commented Sep 12, 2020 •
edited
Loading

@Sean-Der I have fixed the default value at pion/sctp@v1.7.10. (the number 1)

In the change, I also added:

  • MaxMessageSize param to sctp.Config struct
  • MaxMessageSize() to sctp.Association
  • SetMaxMessageSize() to sctp.Association

So that we could accomplish 2 and 3 I mentioned earlier at pion/webrtc (SctpTransport).

enobufs added a commit that referenced this issue Sep 14, 2020
@enobufs
Update pion/sctp and pion/datachannel vers
d4ce7f3 
Relates to #1396
@tarrencev tarrencev added the bug Something isn't working label Sep 16, 2020
@Sean-Der Sean-Der added this to the 3.2.0 milestone Jan 23, 2022
@Sean-Der Sean-Der removed this from the 3.2.0 milestone May 22, 2022
@Sean-Der Sean-Der mentioned this issue May 22, 2022
Closed
@melekes melekes mentioned this issue Oct 19, 2022
Open
@daniel-abramov daniel-abramov mentioned this issue Mar 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enobufs enobufs

Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
3 participants
@enobufs @Sean-Der @tarrencev