Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PeerConnection GetStats API #610

Closed
6 of 45 tasks
maxhawkins opened this issue Apr 10, 2019 · 12 comments
Closed
6 of 45 tasks

Implement PeerConnection GetStats API #610

maxhawkins opened this issue Apr 10, 2019 · 12 comments
Assignees
@obasajujoshua31
Labels
difficulty:hard

Comments

@maxhawkins
Copy link
Contributor

maxhawkins commented Apr 10, 2019 •
edited by tarrencev

Summary

Add support for the PeerConnection GetStats method, conforming to the dom-rtcstats spec.

Motivation

Exposing this API makes it easier to debug connection problems by exposing statistics on lower-level components of the API. Using this standard format will allow our implementation to be interoperable with stats analysis tooling created for the browser's getStats method.

Mandatory Stats

An implementation MUST support generating statistics of the following types when the corresponding objects exist on a PeerConnection, with the attributes that are listed when they are valid for that object:

  • RTCRTPStreamStats
  • RTCReceivedRTPStreamStats
  • RTCInboundRTPStreamStats
  • RTCRemoteInboundRTPStreamStats
  • RTCSentRTPStreamStats
  • RTCOutboundRTPStreamStats
  • RTCRemoteOutboundRTPStreamStats
  • RTCPeerConnectionStats
  • RTCDataChannelStats
  • RTCMediaStreamStats
  • RTCMediaStreamTrackStats
  • RTCMediaHandlerStats
  • RTCAudioHandlerStats
  • RTCVideoHandlerStats
  • RTCVideoSenderStats
  • RTCVideoReceiverStats
  • RTCCodecStats
  • RTCTransportStats
  • RTCIceCandidatePairStats
  • RTCIceCandidateStats
  • RTCCertificateStats

Missing attributes on implemented stats

The fields are there, but they are not actually properly loaded

RTCICECandidatePairStats

  • PacketsSent
  • PacketsReceived
  • BytesSent
  • BytesReceived
  • LastPacketSentTimestamp
  • LastPacketReceivedTimestamp
  • FirstRequestTimestamp
  • LastRequestTimestamp
  • LastResponseTimestamp
  • TotalRoundTripTime
  • CurrentRoundTripTime
  • AvailableOutgoingBitrate
  • AvailableIncomingBitrate
  • CircuitBreakerTriggerCount
  • RequestsReceived
  • RequestsSent
  • ResponsesReceived
  • ResponsesSent
  • RetransmissionsReceived
  • RetransmissionsSent
  • ConsentRequestsSent
  • ConsentExpiredTimestamp

RTCIceCandidateStats

  • URL
  • Deleted (for local candidates only)
@maxhawkins maxhawkins changed the title Implement getStats API Implement PeerConnection GetStats API Apr 10, 2019
maxhawkins added a commit that referenced this issue Apr 10, 2019
@maxhawkins
Begin adding Stats-related structs.
a8082b9 
Definitions from https://www.w3.org/TR/webrtc/#dom-rtcstats

Related to #610
@maxhawkins maxhawkins mentioned this issue Apr 10, 2019
Merged
maxhawkins added a commit that referenced this issue Apr 10, 2019
@maxhawkins
Begin adding Stats-related structs.
e16fd4f 
Definitions from https://www.w3.org/TR/webrtc/#dom-rtcstats

Related to #610
maxhawkins added a commit that referenced this issue Apr 10, 2019
@maxhawkins
Add Stats-related structs.
562d595 
Definitions from https://www.w3.org/TR/webrtc/#dom-rtcstats

Related to #610
maxhawkins added a commit that referenced this issue Apr 10, 2019
@maxhawkins
Add Stats-related structs.
06e0943 
Definitions from https://www.w3.org/TR/webrtc/#dom-rtcstats

Related to #610
maxhawkins added a commit that referenced this issue Apr 10, 2019
@maxhawkins
Add no-op GetStats method
adddd7a 
Related to #610
maxhawkins added a commit that referenced this issue Apr 10, 2019
@maxhawkins
Add Stats-related structs.
66ffe3a 
Definitions from https://www.w3.org/TR/webrtc/#dom-rtcstats

Related to #610
maxhawkins added a commit that referenced this issue Apr 10, 2019
@maxhawkins
Add no-op GetStats method
e7729a7 
Related to #610
maxhawkins added a commit that referenced this issue Apr 10, 2019
@maxhawkins
Add Stats-related structs.
2aa299a 
Definitions from https://www.w3.org/TR/webrtc/#dom-rtcstats

Related to #610
maxhawkins added a commit that referenced this issue Apr 10, 2019
@maxhawkins
Add no-op GetStats method
e8adb27 
Related to #610
maxhawkins added a commit that referenced this issue Apr 10, 2019
@maxhawkins
Add Stats-related structs
232d7d5 
Definitions from https://www.w3.org/TR/webrtc/#dom-rtcstats

Related to #610
maxhawkins added a commit that referenced this issue Apr 10, 2019
@maxhawkins
Add no-op GetStats method
b29d7e3 
Related to #610
This was referenced Apr 12, 2019
Closed
Closed
maxhawkins added a commit that referenced this issue Apr 17, 2019
@maxhawkins
Add Stats-related structs
a37fdd2 
Definitions from https://www.w3.org/TR/webrtc/#dom-rtcstats

Related to #610
maxhawkins added a commit that referenced this issue Apr 17, 2019
@maxhawkins
Add no-op GetStats method
a9554e1 
Related to #610
maxhawkins added a commit that referenced this issue Apr 18, 2019
@maxhawkins
game the coverage: add a dumb test
7f65eac 
Related to #610
maxhawkins added a commit that referenced this issue Apr 18, 2019
@maxhawkins
Name the coverage: add a dumb test
aad5dd3 
Related to #610
Sean-Der pushed a commit that referenced this issue Apr 19, 2019
@maxhawkins @Sean-Der
Add Stats-related structs
5a9bce1 
Definitions from https://www.w3.org/TR/webrtc/#dom-rtcstats

Related to #610
Sean-Der pushed a commit that referenced this issue Apr 19, 2019
@maxhawkins @Sean-Der
Name the coverage: add a dumb test
8c6d714 
Related to #610
maxhawkins added a commit that referenced this issue Apr 21, 2019
@maxhawkins
Clean up stats structs / remove Stats interface
d28a01c 
Related to #610
maxhawkins added a commit that referenced this issue Apr 21, 2019
@maxhawkins
Add Stats-related structs
2327431 
Definitions from https://www.w3.org/TR/webrtc/#dom-rtcstats

Related to #610
maxhawkins added a commit that referenced this issue Apr 21, 2019
@maxhawkins
Name the coverage: add a dumb test
402293b 
Related to #610
maxhawkins added a commit that referenced this issue Apr 21, 2019
@maxhawkins
Clean up stats structs / remove Stats interface
3d2c1c2 
Related to #610
@xsbchen
Copy link
Member

xsbchen commented May 14, 2019 •
edited

any updates？

@maxhawkins
Copy link
Contributor Author

I got pulled away to another project so I'm not working on this currently, unfortunately.

If you want to take a stab at wiring up some of the structs I'd be happy to do a code review.

@maxhawkins
Copy link
Contributor Author

maxhawkins commented Jun 27, 2019 •
edited

Work has started on this. Thank you @hugoArregui!

Only RTCPeerConnectionStats, RTCIceCandidatePairStats, and RTCIceCandidateStats are implemented at the moment. We're looking for help implementing the other stat types.

Here's the commit adding GetStats: 9326196

@hugoArregui hugoArregui mentioned this issue Jul 9, 2019
Closed
obasajujoshua31 added a commit that referenced this issue Sep 21, 2020
@obasajujoshua31
Add GetMediaStats to StatsReport
2084b86 
Add an API to get basic stats around certificate

Relates to #610
obasajujoshua31 added a commit that referenced this issue Sep 22, 2020
@obasajujoshua31
Add GetMediaStats to StatsReport
eecb7ec 
Add an API to get basic stats around certificate

Relates to #610
obasajujoshua31 added a commit that referenced this issue Sep 22, 2020
@obasajujoshua31
Add GetSenderStats to StatsReport
3c75986 
Add an API to get basic stats around rtpsender.

Relates to #610
@obasajujoshua31 obasajujoshua31 mentioned this issue Sep 22, 2020
Closed
obasajujoshua31 added a commit that referenced this issue Sep 22, 2020
@obasajujoshua31
Add GetMediaStats to StatsReport
7f24531 
Add an API to get basic stats around certificate

Relates to #610
obasajujoshua31 added a commit that referenced this issue Sep 22, 2020
@obasajujoshua31
Add GetMediaStats to StatsReport
1a2a67f 
Add an API to get basic stats around certificate

Relates to #610
obasajujoshua31 added a commit that referenced this issue Sep 22, 2020
@obasajujoshua31
Add GetMediaStats to StatsReport
f0d26f9 
Add an API to get basic stats around certificate

Relates to #610
obasajujoshua31 added a commit that referenced this issue Sep 22, 2020
@obasajujoshua31
Add GetMediaStats to StatsReport
a4f70fd 
Add an API to get basic stats around certificate

Relates to #610
tarrencev pushed a commit that referenced this issue Sep 22, 2020
@obasajujoshua31 @tarrencev
Add GetMediaStats to StatsReport
9d39390 
Add an API to get basic stats around certificate

Relates to #610
obasajujoshua31 added a commit that referenced this issue Sep 22, 2020
@obasajujoshua31
Add GetMediaStats to StatsReport
1e0b94c 
Add an API to get basic stats around media.

Relates to #610
obasajujoshua31 added a commit that referenced this issue Sep 22, 2020
@obasajujoshua31
Add GetMediaStats to StatsReport
418b521 
Add an API to get basic stats around media.

Relates to #610

mend
tarrencev pushed a commit that referenced this issue Sep 22, 2020
@obasajujoshua31 @tarrencev
Add GetMediaStats to StatsReport
7d79c76 
Add an API to get basic stats around media.

Relates to #610

mend
obasajujoshua31 added a commit that referenced this issue Sep 23, 2020
@obasajujoshua31
Add GetMediaStats to StatsReport
363ab9a 
Add an API to get basic stats around rtpsender.

Add an API to get basic stats around rtpreceiver

Relates to #610
obasajujoshua31 added a commit that referenced this issue Sep 23, 2020
@obasajujoshua31
Add GetMediaStats to StatsReport
3ad720b 
Add an API to get basic stats around rtpsender.

Add an API to get basic stats around rtpreceiver

Relates to #610
obasajujoshua31 added a commit that referenced this issue Sep 23, 2020
@obasajujoshua31
Add GetMediaStats to StatsReport
bcd83e7 
Add an API to get basic stats around rtpsender.

Add an API to get basic stats around rtpreceiver

Relates to #610
obasajujoshua31 added a commit that referenced this issue Sep 23, 2020
@obasajujoshua31
Add GetMediaStats to StatsReport
ecb1430 
Add an API to get basic stats around rtpsender.

Add an API to get basic stats around rtpreceiver

Relates to #610
obasajujoshua31 added a commit that referenced this issue Sep 24, 2020
@obasajujoshua31
Add an API to get basic stats around stream stats.
e39e854 
Relates to #610

stats around outboundrtpstreamstats

Description
Reference issue
Fixes #...
@obasajujoshua31 obasajujoshua31 mentioned this issue Sep 24, 2020
Closed
obasajujoshua31 added a commit that referenced this issue Sep 24, 2020
@obasajujoshua31
Add an API to get basic stats around mediaStream.
8e280f2 
Relates to #610

Description
Reference issue
Fixes #...
@obasajujoshua31 obasajujoshua31 mentioned this issue Sep 24, 2020
Closed
obasajujoshua31 added a commit that referenced this issue Sep 24, 2020
@obasajujoshua31
Add an API to get basic stats around mediaStream.
09f5e62 
Relates to #610

Description
Reference issue
Fixes #...
obasajujoshua31 added a commit that referenced this issue Sep 24, 2020
@obasajujoshua31
Add an API to get basic stats around mediaStream.
c99564c 
Relates to #610

Description
Reference issue
Fixes #...
obasajujoshua31 added a commit that referenced this issue Sep 25, 2020
@obasajujoshua31
Add an API to get basic stats around inboundstream.
1dbe80f 
Added stats to support inboundrtpstreamstats

added helper function and test for atomicuint

Relates to #610

Description
Reference issue
Fixes #...
@obasajujoshua31 obasajujoshua31 mentioned this issue Sep 25, 2020
Closed
obasajujoshua31 added a commit that referenced this issue Sep 25, 2020
@obasajujoshua31
Add an API to get basic stats around inboundstream.
63a126e 
Added stats to support inboundrtpstreamstats

added helper function and test for atomicuint

Relates to #610

Description
Reference issue
Fixes #...
@tubzby tubzby mentioned this issue Sep 16, 2021
Closed
@hiteshgarg14
Copy link

Hi, is there any plan to work on this ticket?

@Sean-Der Sean-Der removed the triaged label Mar 29, 2024
@Sean-Der
Copy link
Member

Sean-Der commented Apr 4, 2024

Hi @hiteshgarg14

I think this is a task that will never be done. It can always be better. I am resolving since we don't have anything actionable out of this.

@Sean-Der Sean-Der closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obasajujoshua31 obasajujoshua31

Labels
difficulty:hard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@maxhawkins @enobufs @hugoArregui @xsbchen @Sean-Der @hiteshgarg14 @somersbmatthews @obasajujoshua31