Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote raw rtp reader #1582

Closed
wants to merge 1 commit into from
Closed

Conversation

OrlandoCo
Copy link
Contributor

Description

This method will help getting the raw rtp packet from interceptors

Depends on

pion/interceptor#12

This method will help getting the raw rtp packet from interceptors
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #1582 (3fbbc38) into master (0dea1f9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1582      +/-   ##
==========================================
- Coverage   74.65%   74.63%   -0.02%     
==========================================
  Files          81       81              
  Lines        5681     5685       +4     
==========================================
+ Hits         4241     4243       +2     
- Misses       1063     1064       +1     
- Partials      377      378       +1     
Flag Coverage Δ
go 76.17% <100.00%> (-0.03%) ⬇️
wasm 70.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
track_remote.go 88.04% <100.00%> (+0.54%) ⬆️
dtlstransport.go 64.82% <0.00%> (-2.02%) ⬇️
peerconnection.go 73.59% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dea1f9...3fbbc38. Read the comment docs.

@Sean-Der
Copy link
Member

Sean-Der commented Dec 7, 2020

oh jeez, this is a bigger problem that I understood at first @OrlandoCo! Read completely ignores interceptors?

@OrlandoCo
Copy link
Contributor Author

OrlandoCo commented Dec 7, 2020

oh jeez, this is a bigger problem that I understood at first @OrlandoCo! Read completely ignores interceptors?

Thats why ReadRTP and others methods call Read instead of read, so if the chain is using raw rtp and the user is reading from ReadRTP it may see the same slice and not a new read

@Sean-Der
Copy link
Member

Closing for #1595

@Sean-Der Sean-Der closed this Dec 13, 2020
@Sean-Der Sean-Der deleted the feat/readrawinterceptor branch December 13, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants