Docs: correct OnBufferedAmountLow condition
#2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2474 +/- ##
==========================================
- Coverage 77.83% 77.65% -0.18%
==========================================
Files 87 87
Lines 9319 9319
==========================================
- Hits 7253 7237 -16
- Misses 1639 1650 +11
- Partials 427 432 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Thank you so much @WofWca! Great fix, just working through the backlog. |
This is in line with
* the docs for 'BufferedAmountLowThreshold' ("When the bufferedAmount
decreases from above this threshold to equal or below it")
* The actual code in 'pion/sctp':
https://github.com/pion/sctp/blob/d6446e3b0d0495d9974e68fec9b7fdb79c018ca1/stream.go#L422
* The Web WebRTC spec:
https://w3c.github.io/webrtc-pc/#event-datachannel-bufferedamountlow
Sean-Der
force-pushed
the
docs-OnBufferedAmountLow
branch
from
10d5b01
to
2996774
Compare
tgragnato
pushed a commit
to tgragnato/snowflake
that referenced
this pull request
Oct 12, 2023
The `dc.Send()` should increase the `bufferedAmount` value, so there is no need to add the message length a second time. Also replace GT with GE, for the case where `BufferedAmountLowThreshold === maxBufferedAmount` Currently the deadlock cannot happen because `maxBufferedAmount` and `BufferedAmountLowThreshold` are too far apart, in fact the former is 2x the latter. See - https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snowflake/-/merge_requests/144#note_2902956 - pion/webrtc#2473 - pion/webrtc#2474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is in line with
BufferedAmountLowThreshold("When the bufferedAmount decreases from above this threshold to equal or below it")pion/sctp: https://github.com/pion/sctp/blob/d6446e3b0d0495d9974e68fec9b7fdb79c018ca1/stream.go#L422This came up in this discussion.
Related: #2473.
Reference issue