Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deletion of existing sample_builder implementation codes #2591

Closed
wants to merge 6 commits into from
Closed

Deletion of existing sample_builder implementation codes #2591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8d7925b
Deletion of existing sample_builder implementation codes
midepeter Sep 25, 2023
fda9a22
Update AUTHORS.txt
midepeter Sep 25, 2023
fc1ac30
Replacing back the former tests to test against the new implementation
midepeter Oct 10, 2023
46372cf
Merge branch 'sample_builder_rebuild' of https://github.com/pion/webr…
midepeter Oct 10, 2023
c53e429
Merge branch 'master' into sample_builder_rebuild
midepeter Dec 9, 2023
3913677
Update AUTHORS.txt
midepeter Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions AUTHORS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ backkem <mail@backkem.me>
baiyufei <baiyufei@outlook.com>
Bao Nguyen <bao@n4n.dev>
Ben Weitzman <benweitzman@gmail.com>
Benjamin Pracht <benjamin@livekit.io>
Benny Daon <benny@tuzig.com>
bkim <bruce.kim.it@gmail.com>
Bo Shi <boshi@mural.co>
Expand Down Expand Up @@ -137,6 +138,7 @@ mchlrhw <4028654+mchlrhw@users.noreply.github.com>
Michael MacDonald <github@macdonald.cx>
Michael MacDonald <mike.macdonald@savantsystems.com>
Michiel De Backker <38858977+backkem@users.noreply.github.com>
midepeter <mosadomipeter@yahoo.com>
Mike Coleman <mc@fivebats.com>
Mikhail <mvrogushkov@sberbank.ru>
Mindgamesnl <matsmoolhuizen@gmail.com>
Expand Down
7 changes: 5 additions & 2 deletions pkg/media/media.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@ import (

// A Sample contains encoded media and timing information
type Sample struct {
Data []byte
Timestamp time.Time
Data []byte
Timestamp time.Time

// Duration has been deprecated since it is difficult to compute correctly
// in all cases and using the timeStamp is the right thing to use
Duration time.Duration
PacketTimestamp uint32
PrevDroppedPackets uint16
Expand Down
53 changes: 0 additions & 53 deletions pkg/media/samplebuilder/sampleSequenceLocation.go
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions pkg/media/samplebuilder/sampleSequenceLocation_test.go
View file
Open in desktop

This file was deleted.

Loading
Loading