Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaxBindingRequests to SettingEngine #2661

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

Sean-Der
Copy link
Member

@Sean-Der Sean-Der commented Feb 3, 2024

No description provided.

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ca0b939) 76.39% compared to head (b1ae21d) 76.38%.

Files Patch % Lines
settingengine.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2661      +/-   ##
==========================================
- Coverage   76.39%   76.38%   -0.02%     
==========================================
  Files          87       87              
  Lines        9905     9908       +3     
==========================================
+ Hits         7567     7568       +1     
- Misses       1867     1869       +2     
  Partials      471      471              
Flag Coverage Δ
go 77.91% <33.33%> (-0.02%) ⬇️
wasm 64.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der merged commit 906f20c into master Feb 3, 2024
15 of 17 checks passed
@Sean-Der Sean-Der deleted the max-binding-requests branch February 3, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants