Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Builder: Use Jitter Buffer implementation #2679

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

thatsnotright
Copy link

Description

This adds a very basic jitter buffer to SampleBuilder which should allow it to buffer some packets before starting to emit samples.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 76.37%. Comparing base (835ac3b) to head (e9b848f).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/media/samplebuilder/samplebuilder.go 77.14% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2679      +/-   ##
==========================================
- Coverage   76.40%   76.37%   -0.04%     
==========================================
  Files          87       87              
  Lines        9947     9963      +16     
==========================================
+ Hits         7600     7609       +9     
- Misses       1875     1880       +5     
- Partials      472      474       +2     
Flag Coverage Δ
go 77.89% <77.14%> (-0.04%) ⬇️
wasm 64.53% <77.14%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der force-pushed the rob/jitterbuffer_samplebuilder branch from d080e21 to e9b848f Compare March 26, 2024 01:37
@Sean-Der Sean-Der merged commit c47f890 into master Mar 26, 2024
17 checks passed
@Sean-Der Sean-Der deleted the rob/jitterbuffer_samplebuilder branch March 26, 2024 01:42
@at-wat
Copy link
Member

at-wat commented Apr 8, 2024

This change seems causing segmentation fault in my code using SampleBuilder. I'll open an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants