Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding support to TrackLocalStaticSample #2745

Closed

Conversation

alexpokotilo
Copy link

To add padding-only samples call GeneratePadding

Description

Sometime for Bandwidth estimation purposes we need to add Padding-only packages to the stream before switching to new rendition. This is TrackLocalStaticSample part of activity started in #251

To add padding-only samples call GeneratePadding
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 77.51%. Comparing base (eb6e395) to head (c106615).
Report is 4 commits behind head on v3.

Files Patch % Lines
track_local_static.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2745      +/-   ##
==========================================
+ Coverage   76.32%   77.51%   +1.18%     
==========================================
  Files          87       87              
  Lines        9846     8111    -1735     
==========================================
- Hits         7515     6287    -1228     
+ Misses       1866     1359     -507     
  Partials      465      465              
Flag Coverage Δ
go 79.00% <0.00%> (+1.14%) ⬆️
wasm 65.09% <ø> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der closed this Apr 9, 2024
@alexpokotilo alexpokotilo deleted the static-sample-padding-support-v3 branch April 10, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants