Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Make initialisms more consistent #418

Merged
merged 4 commits into from
Feb 18, 2019
Merged

API: Make initialisms more consistent #418

merged 4 commits into from
Feb 18, 2019

Conversation

maxhawkins
Copy link
Contributor

Change capitalization to be consistent with other uses in the project, and to match the Go convention of capitalizing initialisms:

https://github.com/golang/go/wiki/CodeReviewComments#initialisms

Relates to #417

@backkem backkem added the review label Feb 18, 2019
@maxhawkins
Copy link
Contributor Author

Looks like I need to update pions/sdp before this can land.

@maxhawkins
Copy link
Contributor Author

SDP change is in review:

pion/sdp#9

@maxhawkins maxhawkins force-pushed the initialisms branch 2 times, most recently from 0d92c8c to 9fcefeb Compare February 18, 2019 19:09
@coveralls
Copy link

coveralls commented Feb 18, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2077

  • 25 of 33 (75.76%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 79.23%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rtpsender.go 3 5 60.0%
peerconnection.go 17 23 73.91%
Files with Coverage Reduction New Missed Lines %
peerconnection.go 2 73.47%
Totals Coverage Status
Change from base Build 2061: 0.1%
Covered Lines: 3891
Relevant Lines: 4911
💛 - Coveralls

@maxhawkins
Rename Ssrc -> SSRC
7551cbb 
This capitalization is consistent with other uses in the project,
and matches the Go convention of capitalizing initialisms.

https://github.com/golang/go/wiki/CodeReviewComments#initialisms

Relates to #417
@maxhawkins
Rename Sdp -> SDP
93c961a 
Relates to #417
@maxhawkins
Rename MacKey -> MACKey
31ddd5a 
Relates to #417
@maxhawkins
Upgrade to pions/sdp v2
d55261e 
Relates to #417
@Sean-Der Sean-Der merged commit 9cba54c into master Feb 18, 2019
@Sean-Der Sean-Der removed the review label Feb 18, 2019
@Sean-Der Sean-Der deleted the initialisms branch February 19, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sean-Der Sean-Der Sean-Der approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxhawkins @coveralls @Sean-Der @backkem