WASM Detach #565
Merged
WASM Detach #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2779
💛 - Coveralls |
|
Fixed some small bugs in the way |
Port the API object to the JS/WASM target. This allows more code to work for both targets.
JS/WASM shim for Detach API
3 tasks
albrow
reviewed
Apr 1, 2019
| // valueToDataChannelMessage may block when handling 'Blob' data | ||
| // so we need to call it from a new routine. See: | ||
| // https://godoc.org/syscall/js#FuncOf | ||
| msg := valueToDataChannelMessage(data) |
albrow
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Detach when targeting JS/WASM. The goal is to enable the same idiomatic API in both Native and WASM. This is a POC of the shim to turn the JS OnMessage Callback into the ReadWriteCloser interface used by the DataChannel.Detach. I tried to avoid leaking JS code into pions/datachannel by introducing an interface. Therefore this depends on pion/datachannel#11.
TODO