Handle io.ErrShortBuffer error #719
Conversation
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
==========================================
+ Coverage 76.63% 76.64% +<.01%
==========================================
Files 58 58
Lines 4041 4038 -3
==========================================
- Hits 3097 3095 -2
+ Misses 688 687 -1
Partials 256 256
Continue to review full report at Codecov.
|
|
As mentioned in #718, I'm revising this patch to do two things:
|
There was a problem hiding this comment.
@cohosh - I am so sorry for the delay. I was distracted by other issues...
Changes look good and reasonable!
I have just tagged the latest pion/sctp as v1.6.4. Not strictly required but if you could update go.mod before merging, that would be fantastic. (rebase master also)
go get -u github.com/pion/sctp@v1.6.4
go mod tidy
The current dataChannelBufferSize is less than the limit used in WriteSCTP (called by Send), which means that peers using this implementations of WebRTC can send messages that will be thrown out by Read because of an io.ErrShortBuffer error. In the case that the message is too long, a more appropriate response would be to close the channel and issue an error rather than log a warning and continue reading data.
Updated by running the following commands: go get -u github.com/pion/sctp@v1.6.4 go mod tidy
|
Rebased and merged. The last commit updated the go module with the commands you gave. Thanks @enobufs! |
|
Thanks again for getting involved @cohosh If there is anything we can ever do to help I am ears. Really excited/grateful to have people actually using Pion :) |
|
There are various issues/PRs/comments where this is brought up, however, I ran into an issue in some code I am writing where I detach the data channel for use in another protocol on top of the detached datachannel - the protocol's library does a tonne of reads with a buffer with length 1. Is the idea that if you detach the datachannel, you are supposed to handle these use cases on your own? If detaching the datachannel is supposed to act like an io.Reader, for example - requesting that the buffer be made larger to accommodate the io.Read call seems strange to me. |
|
Just to give an update: the latest version of Tor Browser alpha finally has Snowflake available for Windows thanks to switching to the pion/webrtc library https://blog.torproject.org/new-release-tor-browser-90a7 Thanks for all your help with this! \o/ |
|
That if fantastic news @cohosh ! Thank you so much for taking a risk on us, and I am always here to help whenever things come up! Using Pion for Snowflake was one of the original goals for me, so that really makes my day. Thanks :) |
Handle an io.ErrorShortBuffer return from ReadDataChannel by doubling
the size of the buffer and making another read.
Description
When ReadDataChannel returns an
io,ErrShortBuffererror, a subsequent read is made with a larger buffer to ensure the data is not lost.Reference issue
Fixes #718