Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs #30

Merged
merged 7 commits into from
Jan 25, 2019
Merged

Docs #30

merged 7 commits into from
Jan 25, 2019

Conversation

backkem
Copy link
Member

@backkem backkem commented Dec 20, 2018

Cleanup documentation:

  • Added config flags to cmd/client.
  • Migrated pkg/stun to stun. Resolves Migrate STUN #32
  • Added go modules support.
  • Update CI to match pions/webrtc.
  • Fixed lint warnings.
  • Added a more minimal Dockerfile that we could push to Docker Hub.

@coveralls
Copy link

coveralls commented Dec 20, 2018

Pull Request Test Coverage Report for Build 80

  • 19 of 128 (14.84%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 9.781%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/server/stun.go 0 1 0.0%
internal/allocation/allocation.go 1 5 20.0%
internal/allocation/reservation_manager.go 0 13 0.0%
internal/allocation/allocation_manager.go 17 32 53.13%
internal/server/turn.go 0 22 0.0%
internal/server/server.go 0 54 0.0%
Files with Coverage Reduction New Missed Lines %
internal/allocation/allocation_manager.go 2 53.85%
Totals Coverage Status
Change from base Build 68: 0.6%
Covered Lines: 76
Relevant Lines: 777

💛 - Coveralls

Add flags to configure the host and port the client connects to.
Add documentation to the client example.
Add docker file to run the client example.
Resolves #32
Adds dependency management using Go modules.
Update CI to match pions/webrtc setup.
This fixes the lint warnings detected by the updated CI.
@Sean-Der Sean-Der merged commit eeda63b into master Jan 25, 2019
@Sean-Der Sean-Der removed the review label Jan 25, 2019
@backkem backkem deleted the docs branch January 25, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants