New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on require 'github_api' #325

Merged

piotrmurach merged 1 commit into piotrmurach:master from gekola:fix-unitialized-const-version

Oct 7, 2017

Contributor

gekola commented Oct 7, 2017

Without this patch I get the following error on require 'github_api'

rescue in block (2 levels) in require': There was an error while trying to load the gem 'github_api'. (Bundler::GemRequireError)
Gem Load Error is: uninitialized constant Github::VERSION
Backtrace for gem load error is:
.../github_api-0.18.0/lib/github_api/configuration.rb:47:in `<class:Configuration>'
more backtrace

houndci-bot reviewed

View reviewed changes

lib/github_api/configuration.rb Outdated

@@ @@ -1,6 +1,7 @@ @@
               # encoding: utf-8
               require_relative 'api/config'
+              #require_relative 'version'

houndci-bot Oct 7, 2017

Missing space after #.

houndci-bot reviewed

View reviewed changes

lib/github_api/configuration.rb

@@ @@ -1,6 +1,7 @@ @@
               # encoding: utf-8
               require_relative 'api/config'
+              require_relative 'version'

houndci-bot Oct 7, 2017

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.


          Fix crash on require 'github_api'

48e2560

coveralls commented Oct 7, 2017 •

edited

Loading

Coverage remained the same at 95.417% when pulling 0bda284 on gekola:fix-unitialized-const-version into a5bfbd7 on piotrmurach:master.

coveralls commented Oct 7, 2017 •

edited

Loading

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560 on gekola:fix-unitialized-const-version into a5bfbd7 on piotrmurach:master.

6 similar comments

coveralls commented Oct 7, 2017

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560 on gekola:fix-unitialized-const-version into a5bfbd7 on piotrmurach:master.

coveralls commented Oct 7, 2017

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560 on gekola:fix-unitialized-const-version into a5bfbd7 on piotrmurach:master.

coveralls commented Oct 7, 2017

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560 on gekola:fix-unitialized-const-version into a5bfbd7 on piotrmurach:master.

coveralls commented Oct 7, 2017

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560 on gekola:fix-unitialized-const-version into a5bfbd7 on piotrmurach:master.

coveralls commented Oct 7, 2017

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560 on gekola:fix-unitialized-const-version into a5bfbd7 on piotrmurach:master.

coveralls commented Oct 7, 2017 •

edited

Loading

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560 on gekola:fix-unitialized-const-version into a5bfbd7 on piotrmurach:master.

coveralls commented Oct 7, 2017 •

edited

Loading

Coverage increased (+0.0004%) to 95.417% when pulling 48e2560 on gekola:fix-unitialized-const-version into a5bfbd7 on piotrmurach:master.

piotrmurach merged commit 1727e60 into piotrmurach:master

Owner

piotrmurach commented Oct 7, 2017

Thanks! ❤️

gekola deleted the fix-unitialized-const-version branch

October 7, 2017 13:26

Owner

piotrmurach commented Oct 7, 2017

Sorry for releasing such borked version of the library, I've yanked the v0.18.0 and released v0.18.1 with your patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet