[Bug] Use default arguments instead of short circuiting or conditionals

[peter-gribanov]

You broke your code.
https://github.com/jupeter/clean-code-php#use-default-arguments-instead-of-short-circuiting-or-conditionals

Original is good

function createMicrobrewery($name = null) {
    $breweryName = $name ?: 'Hipster Brew Co.';
    var_dump($breweryName);
}
createMicrobrewery();
createMicrobrewery('');
createMicrobrewery(null);
createMicrobrewery('foo');

Result

string(16) "Hipster Brew Co."
string(16) "Hipster Brew Co."
string(16) "Hipster Brew Co."
string(3) "foo"

Your "good"

function createMicrobrewery($breweryName = 'Hipster Brew Co.') {
    var_dump($breweryName);
}
createMicrobrewery();
createMicrobrewery('');
createMicrobrewery(null);
createMicrobrewery('foo');

Result

string(16) "Hipster Brew Co."
string(0) ""
NULL
string(3) "foo"

Result is different. You broke your code.

[piotrplenik]

Good point.
Do you have propose of better example?

[peter-gribanov]

Problem is fixed in #26