[Bugfix] Use default arguments in PHP 7+ #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this can be merged. Ping @jupeter |
README.md
Outdated
| **Good**: | ||
| **Not bad:** | ||
|
|
||
| This opinion is understandable than the previous version, but it better controls the value of the variable. |
There was a problem hiding this comment.
Should it be
This opinion is more understandable than the previous version
?
There was a problem hiding this comment.
I fixed it. Thanks
|
Merging, thank you for the work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #14
Impossible use NULL if type of argument is declared.
https://3v4l.org/pvHki
https://3v4l.org/CNgtY