Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos and funny grammar #165

Merged
merged 9 commits into from
Mar 19, 2023
Merged

Fix some typos and funny grammar #165

merged 9 commits into from
Mar 19, 2023

Conversation

ThatRedKite
Copy link
Contributor

@ThatRedKite ThatRedKite commented Mar 19, 2023

I tried to make to make some Strings more easy to understand by rewording them or replacing the whole sentence.
I also tried to ensure some correct capitalisation (e.g. steam -> Steam). I hope i didn't break anything :trollface:

I fixed some typos / wonky sounding sentences
I tried to make them sound more natural and easy to understand. I also changed some capitalisation to make it correct (e. g. steam -> Steam)
I tried to fix grammar and some typos to make some messages more clear to the users. I also tried to fix the capitalisation but i might have "fixed" them in a string that gets put into `.toUpper()` which does not change anything, lol.
@piotrulos
Copy link
Owner

I don't see any issues that could break anything.

Just before merging, if you could also add to this PR: "MSCLoader/Properties/AssemblyInfo.cs", and bump version numbers at the bottom of this file from 1.2.11.284 to 1.2.11.285.
This could make easier for me to convert this into update file.

@piotrulos piotrulos self-requested a review March 19, 2023 17:54
@ThatRedKite
Copy link
Contributor Author

I don't see any issues that could break anything.

Just before merging, if you could also add to this PR: "MSCLoader/Properties/AssemblyInfo.cs", and bump version numbers at the bottom of this file from 1.2.11.284 to 1.2.11.285. This could make easier for me to convert this into update file.

Done.

@piotrulos piotrulos merged commit fea12fa into piotrulos:master Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants