Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration docs #1816

Merged
merged 7 commits into from
Apr 2, 2021
Merged

Add migration docs #1816

merged 7 commits into from
Apr 2, 2021

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Rel #1792

Does this PR introduce a user-facing change?:

Add migration docs

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.90%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.90%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.90%. This pull request does not change code coverage.

Copy link
Member

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

@@ -0,0 +1,7 @@
---
title: "Operations"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about placing these docs under the /operator-manual/control-plane/ dir? I feel all of them are the information needed for the control-plane operator.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get your point 👍 I was thinking that way at first but in a second thought, I want to make a group contains kinds of guidelines or step-by-step operation tutorial (not only for the control-plane operator but also the piped management). How do you think about that 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel you. I got what you're wanting to do. But honestly, I would prefer to explicitly divide the operator manual into two sections, Control-plane and Piped.

The reason why is because initially we kind of defined the three actors bondary:

  • User
  • Piped Operator
  • Control-plane Operator

And, we wanted to make it so that control-plane operators only had to look at a certain page. (As well as Piped operators only had to look at a certain page)

I want to make a group contains kinds of guidelines or step-by-step operation tutorial

I feel the same way. I also think we need more tutorials and to organize them in a single group. For tutorials that involve more than one area (including Piped and Control-plane), they should be placed in this new operations section. But I feel like this migration guide is slightly different from it.

But I can't say the current documentation structure is enough readable for all users. So some kinds of transformation are obviously needed. Let's wait for @nghialv 's thought!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think we need more tutorials and to organize them in a single group.

More than agree 😂

we wanted to make it so that control-plane operators only had to look at a certain page.

You convinced me, I started thinking as my first thought already 🤔 But let's wait for some other idea 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think they should be at /operator-manual/control-plane/operations because those operations are just for control-plane operators.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nghialv Thank you for looking over them!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nghialv just to clarify, will we create /operator-manual/control-plane/operations directory and place this migrate-datastore post to that directory 👀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The path of this file should be docs/content/en/docs/operator-manual/operations/control-plane/datastore-migration.md.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.90%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.90%. This pull request does not change code coverage.

@nakabonne
Copy link
Member

nakabonne commented Apr 2, 2021

Thank you. I'm gonna say datastore-migration.md is a little bit versatile, so how about migrate-control-plane-datastore-to-mysql.md or something like that?

@khanhtc1202
Copy link
Member Author

Thank you. I'm gonna say datastore-migration.md is a little bit versatile, so how about migrate-Control-plane-datastore-to-mysql.md or something like that?

That's better 👍 Adopted your suggestion 🙆‍♀️

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.90%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Apr 2, 2021

/lgtm

@pipecd-bot pipecd-bot added the lgtm label Apr 2, 2021
@nakabonne
Copy link
Member

Thanks!
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 94e2f9c into master Apr 2, 2021
@pipecd-bot pipecd-bot deleted the add-migration-docs branch April 2, 2021 08:24
@nghialv
Copy link
Member

nghialv commented Apr 2, 2021

/changelog

@pipecd-bot
Copy link
Collaborator

CHANGELOG

@nghialv: Changelog has been generated in response to this comment.

Details

Changelog since v0.9.9

Notable Changes

  • Add migration docs (#1816)
  • Fix clearing filter for applications (#1819)
  • Fix a bug that the form is not cleared after adding an application (#1814)
  • Drift detector was configured to consider all maps/slides with a length of zero and nil to be equal (#1812)
  • Add pipectl datastore command (#1806)

Internal Changes

  • Update docsy files (#1815)
  • Ensure schema on the new MySQL datastore before migrate (#1813)
  • Run migration sequentially (#1811)
  • Fix building playground (#1807)
  • Add edit application form tests (#1803)
  • Fix playground build job (#1802)
  • Remove unused dependency (#1801)
  • Increase timeout time for playground building (#1800)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants