Fix to override namespace if set for k8s manifest #3991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently,
pipecd.dev/resource-key
annotation is wrong because of this, which means every key will have beenapiVersion:ResourceKind:default:appName
if not having it in the manifest directly although the namespace is set in theapp.config.yaml
.This will resolve the problem that k8s resources aren't pruned even if running Quick Sync
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: