Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to override namespace if set for k8s manifest #3991

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

knanao
Copy link
Member

@knanao knanao commented Nov 18, 2022

What this PR does / why we need it:
Currently, pipecd.dev/resource-key annotation is wrong because of this, which means every key will have been apiVersion:ResourceKind:default:appName if not having it in the manifest directly although the namespace is set in the app.config.yaml.

This will resolve the problem that k8s resources aren't pruned even if running Quick Sync

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fix the problem that k8s resources are not pruned even if running Quick Sync

@knanao knanao changed the title Fix to override namespace if set Fix to override namespace if set for k8s manifest Nov 18, 2022
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants