-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DetermineVersions rpc to PlannerService #5047
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5047 +/- ##
==========================================
+ Coverage 22.45% 22.47% +0.02%
==========================================
Files 522 522
Lines 57041 57041
==========================================
+ Hits 12809 12822 +13
+ Misses 43204 43192 -12
+ Partials 1028 1027 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MEMO:
The implementation will be something like this.
pipecd/pkg/app/piped/planner/kubernetes/kubernetes.go
Lines 501 to 503 in 5acc6e1
// determineVersions decides artifact versions of an application. | |
// It finds all container images that are being specified in the workload manifests then returns their names, version numbers, and urls. | |
func determineVersions(manifests []provider.Manifest) ([]*model.ArtifactVersion, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What this PR does / why we need it:
Which issue(s) this PR fixes:
Follow PR #5015
Does this PR introduce a user-facing change?: