Add rfc for k8s multi cluster deployment #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5069 +/- ##
==========================================
- Coverage 22.82% 22.81% -0.01%
==========================================
Files 409 409
Lines 43338 43338
==========================================
- Hits 9891 9889 -2
- Misses 32668 32671 +3
+ Partials 779 778 -1 ☔ View full report in Codecov by Sentry. |
ffjlabo
force-pushed
the
add-rfc-for-multi-cluster-deploy
branch
from
71522ab
to
668b2c4
Compare
ffjlabo
requested review from
nghialv,
khanhtc1202,
kentakozuka,
t-kikuc and
Warashi
as code owners
t-kikuc
reviewed
Jul 30, 2024
| # Usecase | ||
| - case 1. When applying the same manifest to multiple clusters for redundant configuration | ||
| - case 2. When applying manifest with some patches applied to multiple clusters for redundant configuration | ||
| - case 3. Blue/Green Deployment acress the clusters |
There was a problem hiding this comment.
[nits]
Suggested change
| - case 3. Blue/Green Deployment acress the clusters | |
| - case 3. Blue/Green Deployment across clusters |
| ### Register Application with multiple platform providers | ||
|
|
||
| On the application register part, we can choose multiple platform providers. | ||
| At first, user add the first platform provider. |
There was a problem hiding this comment.
Suggested change
| At first, user add the first platform provider. | |
| At first, a user adds the first platform provider. |
|
|
||
|  | ||
|
|
||
| Also, we can can the list of platform providers on the piped list page to verify the platform providers. |
There was a problem hiding this comment.
[nits] plz correct the verb.
Suggested change
| Also, we can can the list of platform providers on the piped list page to verify the platform providers. | |
| Also, we can xxx the list of platform providers on the piped list page to verify the platform providers. |
| - K8S_BASELINE_CLEAN | ||
| - K8S_TRAFFIC_ROUTING | ||
|
|
||
| ### How to check the stage progress of each platform providers in the deployment |
There was a problem hiding this comment.
Suggested change
| ### How to check the stage progress of each platform providers in the deployment | |
| ### How to check the stage progress of each platform provider in the deployment |
Comment on lines
319
to
320
|
|
||
| - Rollback時 |
There was a problem hiding this comment.
these lines should be removed??
Suggested change
| - Rollback時 |
ffjlabo
force-pushed
the
add-rfc-for-multi-cluster-deploy
branch
from
ceadcab
to
7983df8
Compare
|
@t-kikuc Thank you for the verbal comment! I fixed them 🙏 |
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
ffjlabo
force-pushed
the
add-rfc-for-multi-cluster-deploy
branch
from
7983df8
to
4ad31cd
Compare
t-kikuc
approved these changes
Aug 2, 2024
khanhtc1202
approved these changes
Aug 9, 2024
This was referenced Aug 13, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
as title
Which issue(s) this PR fixes:
Part of #5006
Does this PR introduce a user-facing change?: