Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] change the order of managing-piped, managing-controlplane #5119

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Aug 8, 2024

What this PR does / why we need it:

I changed the order under UserGuide.

Managing application/piped/ControlPlane should be close to each other and at the top of the UserGuide section.

Current:
image

New:
image

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.78%. Comparing base (34363a8) to head (9d491ab).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5119      +/-   ##
==========================================
- Coverage   22.78%   22.78%   -0.01%     
==========================================
  Files         412      412              
  Lines       43863    43863              
==========================================
- Hits         9996     9992       -4     
- Misses      33080    33083       +3     
- Partials      787      788       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@t-kikuc t-kikuc merged commit 2d048c6 into master Aug 8, 2024
18 checks passed
@t-kikuc t-kikuc deleted the doc-order branch August 8, 2024 05:39
This was referenced Aug 13, 2024
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants