Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --app-manifest-cache-count on helm chart #5142

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Aug 16, 2024

What this PR does / why we need it:

as title

Which issue(s) this PR fixes:

Fixes #5141
Follow #5108

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.80%. Comparing base (614e054) to head (1d4ece0).
Report is 124 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5142   +/-   ##
=======================================
  Coverage   22.80%   22.80%           
=======================================
  Files         412      412           
  Lines       43827    43827           
=======================================
  Hits         9996     9996           
  Misses      33044    33044           
  Partials      787      787           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go 👍

@ffjlabo ffjlabo merged commit c9861c7 into master Aug 16, 2024
18 checks passed
@ffjlabo ffjlabo deleted the add-app-manifest-cache-count-on-helm-chart branch August 16, 2024 04:31
kumo-rn5s pushed a commit to kumo-rn5s/pipecd that referenced this pull request Aug 16, 2024
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: kumo-rn5s <firosstuart@gmail.com>
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
github-actions bot pushed a commit that referenced this pull request Sep 3, 2024
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
ffjlabo added a commit that referenced this pull request Sep 3, 2024
* Support --app-manifest-cache-count on helm chart (#5142)

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Update release to v0.48.8 (#5176)

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

---------

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support appManifestCacheCount Helm Chart value for piped flag --app-manifest-cache-count
3 participants