Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove faq for k8s multicluster rollout #5153

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Aug 20, 2024

What this PR does / why we need it:

Currently, PIpeCD can't support the feature for now.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ffjlabo ffjlabo enabled auto-merge (squash) August 20, 2024 05:33
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.78%. Comparing base (c0d5b79) to head (07369f1).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5153      +/-   ##
==========================================
- Coverage   22.79%   22.78%   -0.01%     
==========================================
  Files         412      412              
  Lines       43827    43827              
==========================================
- Hits         9992     9988       -4     
- Misses      33047    33050       +3     
- Partials      788      789       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good bye and see you later 👋

@ffjlabo ffjlabo merged commit 6301594 into master Aug 27, 2024
18 checks passed
@ffjlabo ffjlabo deleted the remove-faq-for-mluti-clusters branch August 27, 2024 13:38
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants