Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix due date for update activity mapping #34

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Fix due date for update activity mapping #34

merged 1 commit into from
Mar 24, 2021

Conversation

mykhailo-riabokon
Copy link
Contributor

@mykhailo-riabokon mykhailo-riabokon commented Mar 24, 2021 •
edited
Loading

Problem

updateEditAnActivity did not take into account dueDate as autocreated mapping was incorrect.

How to test

// should update a due date for an existing activity 
$query['dueDate'] = new DateTime('2021-04-02');
$query['id'] = '<an existing activity id>';

$client->getActivities()->updateEditAnActivity($query);

Related PRs:
#28

SiimKirjanen
SiimKirjanen approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@SiimKirjanen SiimKirjanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mykhailo-riabokon mykhailo-riabokon merged commit a3f6fc0 into master Mar 24, 2021
@mykhailo-riabokon mykhailo-riabokon deleted the fix-update-activity-due-date branch March 24, 2021 10:39
@mykhailo-riabokon mykhailo-riabokon mentioned this pull request Mar 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiimKirjanen SiimKirjanen SiimKirjanen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mykhailo-riabokon @SiimKirjanen