GRAL-2093: make sure all response properties are camelCased #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziimk
force-pushed
the
GRAL-2093-camel-case
branch
2 times, most recently
from
0e988b3
to
a0d98a6
Compare
ziimk
commented
Jul 1, 2021
Comment on lines
+9
to
+11
| if ($input instanceof \DateTime) { | ||
| return $input; | ||
| } |
There was a problem hiding this comment.
We don't want to remap DateTime objects - it caused the actual values to change as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
Every response now goes through
CamelCaseHelper::keysToCamelCase()function because relying on only the model mapper caused inconsistencies (if the model contained a property that is defined just as anobject, not a specific model - like this one - then the keys of this object were not camel-cased).Also, if
json_encode()is run over the response then everything is now consistently snake_cased (as in the raw response)Testing:
composer require pipedrive/pipedrive:dev-GRAL-2093-camel-caseFor example,
$client->getDeals()->getDetailsOfADeal(123);now (left) vs before (right):