Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReturnTypeWillChange attribute for PHP8.1 comp #60

Merged
merged 1 commit into from
May 5, 2023

Conversation

poethrenoff
Copy link
Contributor

No description provided.

Copy link

@teemurautiainen teemurautiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is totally needed and working solution for PHP >=8.1.

@tswagger
Copy link

tswagger commented Jan 30, 2023

The plugin needs to be updated to php 8.x in composer.json as php 7.4 is no longer supported. The function should specify a valid return type (even if that is just : mixed for the time being).

@SpaceOven SpaceOven self-assigned this May 5, 2023
@SpaceOven SpaceOven merged commit cba0652 into pipedrive:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants