Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rendering when both viewbox and width/height attributes are pre… #70

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

MichaelRoosz
Copy link
Collaborator

@MichaelRoosz MichaelRoosz commented Jan 9, 2020

Fixed rendering when both viewbox and width/height attributes are present

@MichaelRoosz MichaelRoosz merged commit 3acbf51 into piqnt:master Jan 9, 2020
@shakiba
Copy link
Collaborator

shakiba commented Jan 10, 2020

Thanks for the PR! :) Do you have a npmjs.com account to publish a new version? (I should add your account, so let me know what your username is.)

@MichaelRoosz
Copy link
Collaborator Author

You are welcome :) Here is my npmjs account: https://www.npmjs.com/~michaelheerklotz (username michaelheerklotz). This would be great, I will switch back to the official package and unpublish my custom one.

@shakiba
Copy link
Collaborator

shakiba commented Jan 11, 2020

👍 I added you to the project, let me know if you need anything else from me, thanks for your contribution!

@MichaelRoosz
Copy link
Collaborator Author

Thank you very much. The code seems pretty stable now, so I have released version 0.4.0 on npmjs and deprecated my fork package (unpublish did not work because more than 72hours have passed since the release).

@shakiba
Copy link
Collaborator

shakiba commented Jan 17, 2020

Amazing, finally an update after 4 years! 😅
Thank you!

@MichaelRoosz MichaelRoosz deleted the puppeteer branch December 15, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants