let components wait for LINSTOR API #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanzenBug
force-pushed
the
linstor-wait-until
branch
from
af11626
to
0d0b043
Compare
WanzenBug
force-pushed
the
linstor-wait-until
branch
from
0d0b043
to
0c965c0
Compare
kvaps
reviewed
Feb 24, 2022
| @@ -676,8 +676,21 @@ func newCSINodeDaemonSet(csiResource *piraeusv1.LinstorCSIDriver) *appsv1.Daemon | |||
| Resources: csiResource.Spec.Resources, | |||
| } | |||
|
|
|||
| linstorWaitNodeInitContainer := corev1.Container{ | |||
| Name: "linstor-wait-node-online", | |||
| Image: csiResource.Spec.LinstorPluginImage, | |||
There was a problem hiding this comment.
Wouldn't it be better to use separate linstor-wait-until image for all components instead of putting its binary into the each component image?
There was a problem hiding this comment.
Another image is another component that needs to be configured, another component that users might need to override/replace. then you have to do this weird song&dance with upgrade CRDs, because that's were they need to be configured, and you might need a default value somewhere in the operator.
so I just skip all that, put it into the containers that need to be downloaded in any case and be done with it.
Merged
WanzenBug
force-pushed
the
linstor-wait-until
branch
from
0c965c0
to
018395f
Compare
The HA Controller and CSI Driver can only run if the LINSTOR api is available. To prevent an initial round of crashed containers, we add init containers with the only purpose of waiting for the LINSTOR API to be available. The used linstor-wait-until binary is included in the docker images itself, so we don't need to add yet another image that needs to be configured. Signed-off-by: Moritz "WanzenBug" Wanzenböck <moritz.wanzenboeck@linbit.com>
WanzenBug
force-pushed
the
linstor-wait-until
branch
from
018395f
to
8409883
Compare
JoelColledge
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HA Controller and CSI Driver can only run if the LINSTOR api is available.
To prevent an initial round of crashed containers, we add init containers with
the only purpose of waiting for the LINSTOR API to be available.
The used linstor-wait-until binary is included in the docker images itself, so
we don't need to add yet another image that needs to be configured.