Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab open and closes #2162

Closed
rdewolff opened this issue Feb 22, 2019 · 3 comments
Closed

New Tab open and closes #2162

rdewolff opened this issue Feb 22, 2019 · 3 comments
Labels

Comments

@rdewolff
Copy link

I have found an issue reported to Connex : kesselborn/conex#303

But am not sure who is responsible for the bug. Just posting here to cross link if needed.

@rdewolff
Copy link
Author

rdewolff commented Mar 4, 2019

The issue has been updated on conex, and @piroor has commented the following :

After testing I've realized why this happens on a case.
https://github.com/kesselborn/conex/blob/master/conex-background.js#L467
Conex tries to open a new tab as a "child" of the original tab, and immediately closes the "parent" tab after the child is opened. On the other hand, TST automatically attaches the new "child" tab to the "parent", but its tree is internally still collapsed. Because the "parent" tab is closed before it becomes expanded, TST closes all children in the collapsed tree.

I think this problem must be fixed by TST side.

Could any of the dev here have a look at this issue? Would be great!

piroor added a commit that referenced this issue Mar 4, 2019
…ned tab is closed immediately" problem with other addons #2162
@piroor
Copy link
Owner

piroor commented Mar 4, 2019

The commit 2233374 should fix this.

@piroor piroor added the fixed label Mar 4, 2019
@piroor
Copy link
Owner

piroor commented May 1, 2019

I close this because outdated.

@piroor piroor closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants