New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request optional permissions without toolbar button #2011

Merged
merged 3 commits into from Aug 28, 2018

Conversation

Projects
None yet
2 participants
@Lej77
Contributor

Lej77 commented Aug 28, 2018

Firefox bug 1382953 has been fixed for Firefox 61 and Firefox ESR 60. This means that we can request optional permissions without using the toolbar button.

This implementation attempts to request the permission without the toolbar button and if that fails it then tries to use the toolbar button instead. This can be useful since it allows permission to be request at times when the user hasn't done one of the interactions required to be allowed to request permissions.

It also tracks if a request is currently pending and cancels all request until the current one is either allowed or denied. If this is not done then the user can click multiple times on the request button and the requests will be queued so that when the current request is denied it will appear again and again until the queue is emptied.

Lej77 added some commits Aug 28, 2018

@piroor piroor merged commit bb1af27 into piroor:master Aug 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Aug 28, 2018

Owner

Thanks a lot!!

Owner

piroor commented Aug 28, 2018

Thanks a lot!!

piroor added a commit to piroor/multipletab that referenced this pull request Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment