feat: use native Node.js histogram support #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
reviewed
Jan 12, 2024
clydin
force-pushed
the
native-histograms
branch
from
f0e2648
to
0970d97
Compare
The histogram related dependencies (`hdr-histogram-js`/`hdr-histogram-percentiles-obj`) have been replaced with the native support present in Node.js. This allows the package to have no required dependencies (with one optional for nice support on linux). The public API surface was kept in place to prevent breaking changes for users. This required a small amount of additional code to mainly transform the percentiles to the previous structure.
clydin
force-pushed
the
native-histograms
branch
from
0970d97
to
d8990a3
Compare
|
Addressed the lint errors. |
metcoder95
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The histogram related dependencies (
hdr-histogram-js/hdr-histogram-percentiles-obj) have been replaced with the native support present in Node.js. This allows the package to have no required dependencies (with one optional for nice support on linux). The public API surface was kept in place to prevent breaking changes for users. This required a small amount of additional code to mainly transform the percentiles to the previous structure.