Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash problem when computer is locked #253

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Fixed crash problem when computer is locked #253

merged 2 commits into from
Jun 15, 2024

Conversation

pit-ray
Copy link
Owner

@pit-ray pit-ray commented Jun 12, 2024

@pit-ray pit-ray added the bug Something isn't working label Jun 12, 2024
@pit-ray pit-ray self-assigned this Jun 12, 2024
@pit-ray
Copy link
Owner Author

pit-ray commented Jun 12, 2024

The crash is caused by the GetCursorPos function failing during locking on the fluent-tray side.
https://github.com/pit-ray/fluent-tray/blob/69bbc2e18724cababacea26a0be2ccbf018ebaf4/include/fluent_tray.hpp#L939-L943

The crash can be prevented by erasing the error handling, but key input will not be accepted.

#196 is also likely caused by GetCursorPos in another location.

@pit-ray
Copy link
Owner Author

pit-ray commented Jun 13, 2024

When locked, the key press message is sent, but the key release message is not sent, so win-vind freezes after recovery.

@pit-ray pit-ray merged commit 965a86a into master Jun 15, 2024
8 checks passed
@pit-ray pit-ray deleted the fix-252 branch June 15, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant