Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken Shuttle test #105

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Fix broken Shuttle test #105

merged 1 commit into from
Dec 21, 2018

Conversation

RitwikGupta
Copy link
Member

The mocked URL was wrong 🤷‍♂️

@RitwikGupta RitwikGupta mentioned this pull request Dec 21, 2018
Closed
azharichenko
azharichenko approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@azharichenko azharichenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not sure how the mock wasn't matching with the actual functions. But it works now!

@azharichenko azharichenko merged commit 7847117 into dev Dec 21, 2018
@azharichenko azharichenko deleted the shuttle_fix branch December 21, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azharichenko azharichenko azharichenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RitwikGupta @azharichenko