Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for updating service instances #14

Closed
ldmberman opened this issue Dec 3, 2015 · 3 comments
Closed

Support for updating service instances #14

ldmberman opened this issue Dec 3, 2015 · 3 comments

Comments

@ldmberman
Copy link

Hi,

I am going to work on adding support for updating service instances. From the start, I would like to discuss things to be sure I keep following the right direction.

These are the public-facing changes I am going to make:

  • Update brokerapi.Service with a PlanUpdatable field:
    ...
    PlanUpdatable bool `json:"plan_updateable"`
  • Extend ServiceBroker with an Update method:
    ...
    Update(instanceID string, details UpdateDetails, asyncAllowed bool) (IsAsync, error)
  • With UpdateDetails declared as:
type UpdateDetails struct {
    ServiceID string `json:"service_id"`
    PlanID string `json:"plan_id"`
    Parameters map[string]interface{} `json:"parameters"`
}

Both the public-facing part and the work to be done under the hood seem very similar to what is done for instance provisioning, and I do not expect to encounter any pitfalls for now.

Looking for your thoughts.

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/109435680.

@craigfurman
Copy link
Contributor

Hi @ldmberman, it turns out we recently committed exactly the same thing.

Unfortunately, we didn't see this suggestion before today.

@ldmberman
Copy link
Author

Anyway, thank you for pushing this work forward.

kirederik pushed a commit that referenced this issue Aug 23, 2019
Refer to #14

[#162386093]

Co-authored-by: Felisia Martini <fmartini@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants