Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(kiln validate): ensure a release source config exists for each release lock #361

Merged

Conversation

crhntr
Copy link
Contributor

@crhntr crhntr commented Mar 16, 2023

This is to fix an issue that occurred when we removed a removed release source.

kiln validate will now fail when a release source for a release specified in the Kilnfile.lock is not found in the Kilnfile.

./Kilnfile.lock

releases:
  - name: banana
    version: 1.2.3
    release_source: missing-release-source

./Kilnfile

release_sources:
  - type: s3
    # id: missing-release-source

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@crhntr crhntr force-pushed the feat/ensure-release-source-exists-for-each-release-lock branch from 1b6be0a to b4a6455 Compare March 16, 2023 23:22
@crhntr crhntr merged commit 45bbe22 into main Mar 20, 2023
@crhntr crhntr deleted the feat/ensure-release-source-exists-for-each-release-lock branch March 20, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants