Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-ssl-certificate should support files and quoted strings #463

Closed
kcboyle opened this issue Jan 17, 2020 · 4 comments
Closed

update-ssl-certificate should support files and quoted strings #463

kcboyle opened this issue Jan 17, 2020 · 4 comments

Comments

@kcboyle
Copy link
Contributor

kcboyle commented Jan 17, 2020

It is unclear that you need to provide --certificate-pem and --private-key-pem as command line objects that are unquoted to update-ssl-certificate

It would be a nice user experience if these could be passed in as files and/or passed in as quoted strings.

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@jghiloni
Copy link

jghiloni commented Feb 7, 2020

I have a similar want/need, and would be happy to contribute a fix. Does it make sense to use the om-standard "config-file instead of cmd line args" paradigm? That'll let folks use secret interpolation without having to pass private keys on the command line

@kcboyle
Copy link
Contributor Author

kcboyle commented Feb 7, 2020

Sure! As long as it supports both (so as not to be a breaking change)
We'd certainly appreciate the PR

@kcboyle
Copy link
Contributor Author

kcboyle commented Feb 12, 2020

Closing this issue. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants