Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

Added a way to run operations in specs when set to run synchronously. Al... #137

Merged
merged 1 commit into from
Apr 20, 2015

Conversation

codeman9
Copy link
Contributor

...so added an appropriate override for canceling operations since it looks like the super implementation is not being called. (verified by seeing if my operation's cancel method was called after calling -[PSHKFakeOperationQueue cancellAllOperations]--it wasn't).

… Also added an appropriate override for canceling operations since it looks like the super implementation is not being called. (verified by seeing if my operation's cancel method was called after calling -[PSHKFakeOperationQueue cancellAllOperations]--it wasn't).
@codeman9
Copy link
Contributor Author

Looks like Travis is missing something.

xcodebuild: error: Unable to find a destination matching the provided destination specifier:
{ platform:iOS Simulator, OS:7.1, name:iPhone 5 }
Available destinations for the "Foundation-StaticLibSpec" scheme:
{ platform:iOS Simulator, id:FFDC0F02-6F2D-4261-A188-36C04B845F57, OS:7.0, name:iPad 2 }
{ platform:iOS Simulator, id:27281F5C-9697-4009-9932-722486AFBBD4, OS:7.1, name:iPad 2 }
{ platform:iOS Simulator, id:32D0747C-DAF9-4EA6-BC66-28EAE7CA357A, OS:8.1, name:iPad 2 }
{ platform:iOS Simulator, id:0A5D20B3-5D34-46F5-99B3-EB4AEA113421, OS:7.0, name:iPad Air }
{ platform:iOS Simulator, id:88AAFE0A-8784-4CDF-997A-4387E38CF85A, OS:7.1, name:iPad Air }
{ platform:iOS Simulator, id:33309D21-9B76-41F2-B16E-8F9B4DB269AE, OS:8.1, name:iPad Air }
{ platform:iOS Simulator, id:62A308F2-3272-4EEA-9CD1-90C2335FD3E8, OS:7.0, name:iPad Retina }
{ platform:iOS Simulator, id:215C68E1-4BE6-4169-B30D-1847CF744474, OS:7.1, name:iPad Retina }
{ platform:iOS Simulator, id:78CCB429-8012-4AB9-BB00-48C945BA1722, OS:8.1, name:iPad Retina }
{ platform:iOS Simulator, id:16E214BA-9A36-489E-81C5-9CCB9604FF8B, OS:7.0, name:iPhone 4s }
{ platform:iOS Simulator, id:DF1BBEDE-90C5-41D9-A11B-8DA659322101, OS:7.1, name:iPhone 4s }
{ platform:iOS Simulator, id:37BC3125-3F35-4B1B-9195-BC5105B115AF, OS:8.1, name:iPhone 4s }
{ platform:iOS Simulator, id:B3581D0A-B151-4F5E-9884-FC5A78CDD908, OS:7.0, name:iPhone 5 }
{ platform:iOS Simulator, id:A3312623-A36D-42FD-BB07-DD817F199572, OS:7.1, name:iPhone 5 }
{ platform:iOS Simulator, id:2DDCAE77-D0F8-4FB1-B9E0-3AFBECA68164, OS:8.1, name:iPhone 5 }
{ platform:iOS Simulator, id:CC4EE950-AC3A-40B9-A360-AD393B8D3D08, OS:7.0, name:iPhone 5s }
{ platform:iOS Simulator, id:9262546F-329F-464B-9706-CD956CE4EC88, OS:7.1, name:iPhone 5s }
{ platform:iOS Simulator, id:604674C2-08C7-4F3E-9910-BB7731045B9A, OS:8.1, name:iPhone 5s }
{ platform:iOS Simulator, id:0569A245-BFFC-4F9D-96BD-BF4D5E28F738, OS:8.1, name:iPhone 6 Plus }
{ platform:iOS Simulator, id:28727EC6-4665-4FC2-B77C-C2C456206044, OS:8.1, name:iPhone 6 }
{ platform:iOS Simulator, id:115F4F5D-C861-4342-A274-D8438126F158, OS:8.1, name:Resizable iPad }
{ platform:iOS Simulator, id:90F9F633-C4A2-499C-82C0-0E2CD82A1829, OS:8.1, name:Resizable iPhone }
******** Build failed ********
The command "rake travis" exited with 1.

@akitchen
Copy link
Contributor

Travis has been having this issue from time to time lately. Not sure why; reading the output seems to indicate the required simulator is in fact present.

Thanks for the patches Cody. We'll look into it more closely soon.

On Thu, Mar 26, 2015 at 8:18 AM, Cody Vandermyn notifications@github.com
wrote:

Looks like Travis is missing something.
xcodebuild: error: Unable to find a destination matching the provided destination specifier:
{ platform:iOS Simulator, OS:7.1, name:iPhone 5 }
Available destinations for the "Foundation-StaticLibSpec" scheme:
{ platform:iOS Simulator, id:FFDC0F02-6F2D-4261-A188-36C04B845F57, OS:7.0, name:iPad 2 }
{ platform:iOS Simulator, id:27281F5C-9697-4009-9932-722486AFBBD4, OS:7.1, name:iPad 2 }
{ platform:iOS Simulator, id:32D0747C-DAF9-4EA6-BC66-28EAE7CA357A, OS:8.1, name:iPad 2 }
{ platform:iOS Simulator, id:0A5D20B3-5D34-46F5-99B3-EB4AEA113421, OS:7.0, name:iPad Air }
{ platform:iOS Simulator, id:88AAFE0A-8784-4CDF-997A-4387E38CF85A, OS:7.1, name:iPad Air }
{ platform:iOS Simulator, id:33309D21-9B76-41F2-B16E-8F9B4DB269AE, OS:8.1, name:iPad Air }
{ platform:iOS Simulator, id:62A308F2-3272-4EEA-9CD1-90C2335FD3E8, OS:7.0, name:iPad Retina }
{ platform:iOS Simulator, id:215C68E1-4BE6-4169-B30D-1847CF744474, OS:7.1, name:iPad Retina }
{ platform:iOS Simulator, id:78CCB429-8012-4AB9-BB00-48C945BA1722, OS:8.1, name:iPad Retina }
{ platform:iOS Simulator, id:16E214BA-9A36-489E-81C5-9CCB9604FF8B, OS:7.0, name:iPhone 4s }
{ platform:iOS Simulator, id:DF1BBEDE-90C5-41D9-A11B-8DA659322101, OS:7.1, name:iPhone 4s }
{ platform:iOS Simulator, id:37BC3125-3F35-4B1B-9195-BC5105B115AF, OS:8.1, name:iPhone 4s }
{ platform:iOS Simulator, id:B3581D0A-B151-4F5E-9884-FC5A78CDD908, OS:7.0, name:iPhone 5 }
{ platform:iOS Simulator, id:A3312623-A36D-42FD-BB07-DD817F199572, OS:7.1, name:iPhone 5 }
{ platform:iOS Simulator, id:2DDCAE77-D0F8-4FB1-B9E0-3AFBECA68164, OS:8.1, name:iPhone 5 }
{ platform:iOS Simulator, id:CC4EE950-AC3A-40B9-A360-AD393B8D3D08, OS:7.0, name:iPhone 5s }
{ platform:iOS Simulator, id:9262546F-329F-464B-9706-CD956CE4EC88, OS:7.1, name:iPhone 5s }
{ platform:iOS Simulator, id:604674C2-08C7-4F3E-9910-BB7731045B9A, OS:8.1, name:iPhone 5s }
{ platform:iOS Simulator, id:0569A245-BFFC-4F9D-96BD-BF4D5E28F738, OS:8.1, name:iPhone 6 Plus }
{ platform:iOS Simulator, id:28727EC6-4665-4FC2-B77C-C2C456206044, OS:8.1, name:iPhone 6 }
{ platform:iOS Simulator, id:115F4F5D-C861-4342-A274-D8438126F158, OS:8.1, name:Resizable iPad }
{ platform:iOS Simulator, id:90F9F633-C4A2-499C-82C0-0E2CD82A1829, OS:8.1, name:Resizable iPhone }
******** Build failed ********

The command "rake travis" exited with 1.

Reply to this email directly or view it on GitHub:
#137 (comment)

tjarratt added a commit to tjarratt/PivotalCoreKit that referenced this pull request Apr 20, 2015
@tjarratt tjarratt mentioned this pull request Apr 20, 2015
@tjarratt
Copy link
Contributor

Looks like the Travis failures finally cleared up after some time, although I had to run that on Travis a few times and it still mysteriously fails.

@codeman9 I thought your idea here was really good, so I backfilled some tests for this behavior over in a separate pull request.

@akitchen akitchen merged commit 6af0db1 into pivotal-legacy:master Apr 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants