Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

UIAlertController spec helpers behavior #161

Merged
merged 1 commit into from
Sep 23, 2015

Conversation

kseebaldt
Copy link
Contributor

Dismiss the alert controller before calling the action. This reflects UIKit behavior.

…g the action

- This more closely resembles actual UIKit behavior
@kseebaldt
Copy link
Contributor Author

I'm wary of relying on PCK (especially stubs) to keep up to date with UIKit behavior. There were some tests on my current project that relied on this behavior.

akitchen added a commit that referenced this pull request Sep 23, 2015
UIAlertController spec helpers behavior
@akitchen akitchen merged commit cd1bfdc into pivotal-legacy:master Sep 23, 2015
@akitchen
Copy link
Contributor

Argh, I merged this too soon. #152 is a more optimal way of factoring this, and has tests which cover it. I'll fix up and push

@kseebaldt
Copy link
Contributor Author

Yes that is better. Don't trust everything I do ;)

@akitchen
Copy link
Contributor

Thanks for bumping this issue, somehow it fell off our radar

On Wed, Sep 23, 2015 at 10:03 AM, Kurtis Seebaldt notifications@github.com
wrote:

Yes that is better. Don't trust everything I do ;)


Reply to this email directly or view it on GitHub
#161 (comment)
.

@idoru
Copy link
Contributor

idoru commented Sep 23, 2015

Indeed; I think I was kicking the Travis can for a few days and got tired of watching the last time I hit retry ;)

--Sam

On Sep 23, 2015, at 1:04 PM, Andrew Kitchen notifications@github.com wrote:

Thanks for bumping this issue, somehow it fell off our radar

On Wed, Sep 23, 2015 at 10:03 AM, Kurtis Seebaldt notifications@github.com
wrote:

Yes that is better. Don't trust everything I do ;)


Reply to this email directly or view it on GitHub
#161 (comment)
.


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants