Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Support Composer 2 #137

Closed
wants to merge 15 commits into from
Closed

Support Composer 2 #137

wants to merge 15 commits into from

Conversation

Qrious
Copy link

@Qrious Qrious commented Oct 17, 2020

No description provided.

@Qrious Qrious linked an issue Oct 17, 2020 that may be closed by this pull request
@Qrious Qrious changed the title Initial changes to support Composer 2 Support Composer 2 Oct 24, 2020
@Qrious
Copy link
Author

Qrious commented Oct 24, 2020

Composer 2.0 is officially released. However our current setup does no longer work, it boils down to the following problem.

So, we would need a way to force Composer to prioritize the install/update/removal of [composer] plugins first, then activating them (if still present), then proceed with the rest of the package operations.

ffraenz/private-composer-installer#25 (comment)

Together with these plugins authors we are in contact with the Composer core developers, and are planning a solution.
The discussion will be moved from that PR to a separate issue on the composer repository.
We'll provide the link to the corresponding issue as soon it's available.

We can't provide a timeframe right now for the definitive fix. We are looking at a short term fix that requires our plugin to be installed globally.

@Qrious
Copy link
Author

Qrious commented Oct 25, 2020

The issue at the composer repository is: composer/composer#9333.
I'm now locally working on using the version from the PR, to test if it fixes the problem.

@Qrious
Copy link
Author

Qrious commented Oct 25, 2020

Status update: We've tested the composer version with the suggested solution and this works correctly. We're awaiting future action of the Composer core developers.

We're not releasing a short-term fix that requires a global install, since we believe a proper solution will be available in a reasonable timeframe. The second main reason for this is, that we believe that having installations with this global plugin still hanging around in the future might result in issues. To conclude, we believe the pro's don't outweigh the con's in this case.

@Qrious
Copy link
Author

Qrious commented Oct 26, 2020

This PR is superseded by #146 , As the composer 2.0 compatibility can be achieved without a breaking change, it will be released as version 2.4 instead of 3.0.

@Qrious Qrious closed this Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Composer 2.0
1 participant