Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"next" should be a peer dependency, not a dependency #17

Closed
michalczukm opened this issue Jul 5, 2023 · 3 comments
Closed

"next" should be a peer dependency, not a dependency #17

michalczukm opened this issue Jul 5, 2023 · 3 comments

Comments

@michalczukm
Copy link

Currently having "next" as a dependency can result in having multiple "next" versions in the consumer app (app which utilizes the next-piwik-pro package). It can lead to not-building app.

I've described the details in the PR: #16.
@wojtekmaj
Copy link

Resolved in c1f59a8

@michalczukm
Copy link
Author

michalczukm commented Feb 6, 2024 •
edited
Loading

Great! Glad to hear that 🥳

@lysy-vlc
Copy link
Contributor

Already implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wojtekmaj @michalczukm @lysy-vlc